Skip to content

chore: explicit optionals everywhere #14535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 11, 2025
Merged

chore: explicit optionals everywhere #14535

merged 11 commits into from
Sep 11, 2025

Conversation

gnufede
Copy link
Member

@gnufede gnufede commented Sep 9, 2025 •
edited by brettlangdon
Loading

Code style: This PR changes implicit optionals to explicit ones (in type annotations)

Read more here: https://github.com/hauntsaninja/no_implicit_optional?tab=readme-ov-file#whats-going-on

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025 •
edited
Loading

CODEOWNERS have been resolved as:

ddtrace/appsec/_ddwaf/ddwaf_types.py                                    @DataDog/asm-python
ddtrace/appsec/_ddwaf/waf.py                                            @DataDog/asm-python
ddtrace/appsec/_ddwaf/waf_mock.py                                       @DataDog/asm-python
ddtrace/appsec/_ddwaf/waf_stubs.py                                      @DataDog/asm-python
ddtrace/contrib/internal/unittest/patch.py                              @DataDog/ci-app-libraries
ddtrace/internal/telemetry/metrics_namespaces.pyi                       @DataDog/apm-python
ddtrace/internal/telemetry/writer.py                                    @DataDog/apm-python
mypy.ini                                                                @DataDog/python-guild @DataDog/apm-core-python
tests/appsec/integrations/fastapi_tests/test_fastapi_appsec_iast.py     @DataDog/asm-python
tests/ci_visibility/api_client/_util.py                                 @DataDog/ci-app-libraries
tests/contrib/integration_registry/registry_update_helpers/integration.py  @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/openai_agents/test_openai_agents_llmobs.py                @DataDog/ml-observability
tests/contrib/pytest/test_pytest.py                                     @DataDog/ci-app-libraries

@gnufede gnufede added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025 •
edited
Loading

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 267 ± 2 ms.

The average import time from base is: 273 ± 4 ms.

The import time difference between this PR and base is: -5.4 ± 0.1 ms.

Import time breakdown

The following import paths have grown:

ddtrace.auto 0.046 ms (0.02%)
ddtrace.bootstrap.sitecustomize 0.046 ms (0.02%)
ddtrace.bootstrap.preload 0.046 ms (0.02%)
multiprocessing 0.046 ms (0.02%)
multiprocessing.context 0.046 ms (0.02%)
multiprocessing.reduction 0.046 ms (0.02%)
pickle 0.046 ms (0.02%)

The following import paths have shrunk:

ddtrace.auto 2.504 ms (0.94%)
ddtrace.bootstrap.sitecustomize 1.758 ms (0.66%)
ddtrace.bootstrap.preload 1.758 ms (0.66%)
ddtrace.internal.remoteconfig.client 0.721 ms (0.27%)
multiprocessing 0.077 ms (0.03%)
multiprocessing.context 0.077 ms (0.03%)
multiprocessing.reduction 0.077 ms (0.03%)
pickle 0.077 ms (0.03%)
_pickle 0.077 ms (0.03%)
ddtrace.settings.profiling 0.037 ms (0.01%)
ddtrace.internal.datadog.profiling.ddup 0.037 ms (0.01%)
ddtrace.internal.datadog.profiling.ddup._ddup 0.037 ms (0.01%)
ddtrace 0.746 ms (0.28%)
ddtrace.internal._unpatched 0.097 ms (0.04%)
subprocess 0.065 ms (0.02%)
contextlib 0.065 ms (0.02%)
json 0.032 ms (0.01%)
json.decoder 0.032 ms (0.01%)
re 0.032 ms (0.01%)
enum 0.032 ms (0.01%)
types 0.032 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Sep 9, 2025 •
edited
Loading

Performance SLOs

Comparing candidate gnufede/mypy-remove-implicit-optional (d3aa4b5) with baseline main (f16de5c)

📈 Performance Regressions (2 suites)
📈 iastaspects - 118/118

✅ add_aspect

Time: ✅ 0.329µs (SLO: <10.000µs 📉 -96.7%) vs baseline: +0.7%

Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.7%

✅ add_inplace_aspect

Time: ✅ 0.331µs (SLO: <10.000µs 📉 -96.7%) vs baseline: -0.3%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.0%

✅ add_inplace_noaspect

Time: ✅ 0.319µs (SLO: <10.000µs 📉 -96.8%) vs baseline: -0.3%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.9%

✅ add_noaspect

Time: ✅ 0.281µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +1.5%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.7%

✅ bytearray_aspect

Time: ✅ 1.326µs (SLO: <10.000µs 📉 -86.7%) vs baseline: -0.9%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.9%

✅ bytearray_extend_aspect

Time: ✅ 1.377µs (SLO: <10.000µs 📉 -86.2%) vs baseline: -1.0%

Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.8%

✅ bytearray_extend_noaspect

Time: ✅ 0.611µs (SLO: <10.000µs 📉 -93.9%) vs baseline: +0.5%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.9%

✅ bytearray_noaspect

Time: ✅ 0.484µs (SLO: <10.000µs 📉 -95.2%) vs baseline: ~same

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +5.0%

✅ bytes_aspect

Time: ✅ 1.288µs (SLO: <10.000µs 📉 -87.1%) vs baseline: +1.0%

Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +4.7%

✅ bytes_noaspect

Time: ✅ 0.494µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +1.6%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.9%

✅ bytesio_aspect

Time: ✅ 1.342µs (SLO: <10.000µs 📉 -86.6%) vs baseline: -0.3%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.0%

✅ bytesio_noaspect

Time: ✅ 0.497µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.7%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.1%

✅ capitalize_aspect

Time: ✅ 0.730µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +0.4%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.8%

✅ capitalize_noaspect

Time: ✅ 0.433µs (SLO: <10.000µs 📉 -95.7%) vs baseline: -0.2%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.7%

✅ casefold_aspect

Time: ✅ 0.737µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.5%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.0%

✅ casefold_noaspect

Time: ✅ 0.369µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.7%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.0%

✅ decode_aspect

Time: ✅ 0.726µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +1.0%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.8%

✅ decode_noaspect

Time: ✅ 0.422µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +1.5%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.0%

✅ encode_aspect

Time: ✅ 0.710µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -0.6%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.8%

✅ encode_noaspect

Time: ✅ 0.400µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.3%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.9%

✅ format_aspect

Time: ✅ 3.348µs (SLO: <10.000µs 📉 -66.5%) vs baseline: -0.5%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.0%

✅ format_map_aspect

Time: ✅ 3.545µs (SLO: <10.000µs 📉 -64.5%) vs baseline: 📈 +12.8%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.1%

✅ format_map_noaspect

Time: ✅ 0.775µs (SLO: <10.000µs 📉 -92.2%) vs baseline: -0.9%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.2%

✅ format_noaspect

Time: ✅ 0.595µs (SLO: <10.000µs 📉 -94.1%) vs baseline: +0.6%

Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +4.6%

✅ index_aspect

Time: ✅ 0.346µs (SLO: <10.000µs 📉 -96.5%) vs baseline: -0.6%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.9%

✅ index_noaspect

Time: ✅ 0.281µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +1.9%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.9%

✅ join_aspect

Time: ✅ 1.248µs (SLO: <10.000µs 📉 -87.5%) vs baseline: +1.2%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.0%

✅ join_noaspect

Time: ✅ 0.489µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.4%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.0%

✅ ljust_aspect

Time: ✅ 10.698µs (SLO: <20.000µs 📉 -46.5%) vs baseline: +0.3%

Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +5.1%

✅ ljust_noaspect

Time: ✅ 0.407µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.2%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.6%

✅ lower_aspect

Time: ✅ 2.236µs (SLO: <10.000µs 📉 -77.6%) vs baseline: ~same

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.7%

✅ lower_noaspect

Time: ✅ 0.365µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.1%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.0%

✅ lstrip_aspect

Time: ✅ 10.875µs (SLO: <20.000µs 📉 -45.6%) vs baseline: +0.4%

Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.9%

✅ lstrip_noaspect

Time: ✅ 0.384µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.5%

Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.7%

✅ modulo_aspect

Time: ✅ 0.933µs (SLO: <10.000µs 📉 -90.7%) vs baseline: -0.3%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.0%

✅ modulo_aspect_for_bytearray_bytearray

Time: ✅ 1.419µs (SLO: <10.000µs 📉 -85.8%) vs baseline: -0.7%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.0%

✅ modulo_aspect_for_bytes

Time: ✅ 0.917µs (SLO: <10.000µs 📉 -90.8%) vs baseline: +0.9%

Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.7%

✅ modulo_aspect_for_bytes_bytearray

Time: ✅ 1.121µs (SLO: <10.000µs 📉 -88.8%) vs baseline: ~same

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.0%

✅ modulo_noaspect

Time: ✅ 0.625µs (SLO: <10.000µs 📉 -93.8%) vs baseline: +0.4%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.6%

✅ replace_aspect

Time: ✅ 5.073µs (SLO: <10.000µs 📉 -49.3%) vs baseline: 📈 +13.6%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.0%

✅ replace_noaspect

Time: ✅ 0.467µs (SLO: <10.000µs 📉 -95.3%) vs baseline: +1.2%

Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +4.5%

✅ repr_aspect

Time: ✅ 0.909µs (SLO: <10.000µs 📉 -90.9%) vs baseline: -0.3%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.0%

✅ repr_noaspect

Time: ✅ 0.411µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -1.3%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.7%

✅ rstrip_aspect

Time: ✅ 11.393µs (SLO: <20.000µs 📉 -43.0%) vs baseline: +5.4%

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.9%

✅ rstrip_noaspect

Time: ✅ 0.380µs (SLO: <10.000µs 📉 -96.2%) vs baseline: ~same

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.0%

✅ slice_aspect

Time: ✅ 0.484µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -0.1%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.1%

✅ slice_noaspect

Time: ✅ 0.442µs (SLO: <10.000µs 📉 -95.6%) vs baseline: -1.0%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.0%

✅ stringio_aspect

Time: ✅ 1.588µs (SLO: <10.000µs 📉 -84.1%) vs baseline: +1.0%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.9%

✅ stringio_noaspect

Time: ✅ 0.714µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +0.4%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.9%

✅ strip_aspect

Time: ✅ 10.999µs (SLO: <20.000µs 📉 -45.0%) vs baseline: +1.1%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.9%

✅ strip_noaspect

Time: ✅ 0.385µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.3%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.9%

✅ swapcase_aspect

Time: ✅ 2.450µs (SLO: <10.000µs 📉 -75.5%) vs baseline: -0.5%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.1%

✅ swapcase_noaspect

Time: ✅ 0.541µs (SLO: <10.000µs 📉 -94.6%) vs baseline: -0.1%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.8%

✅ title_aspect

Time: ✅ 2.389µs (SLO: <10.000µs 📉 -76.1%) vs baseline: -0.5%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.9%

✅ title_noaspect

Time: ✅ 0.504µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.6%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.9%

✅ translate_aspect

Time: ✅ 3.365µs (SLO: <10.000µs 📉 -66.4%) vs baseline: +2.1%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.7%

✅ translate_noaspect

Time: ✅ 1.037µs (SLO: <10.000µs 📉 -89.6%) vs baseline: -0.7%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.9%

✅ upper_aspect

Time: ✅ 2.267µs (SLO: <10.000µs 📉 -77.3%) vs baseline: ~same

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.8%

✅ upper_noaspect

Time: ✅ 0.375µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +1.8%

Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.8%

📈 telemetryaddmetric - 30/30

✅ 1-count-metric-1-times

Time: ✅ 3.505µs (SLO: <20.000µs 📉 -82.5%) vs baseline: 📈 +11.4%

Memory: ✅ 31.418MB (SLO: <34.000MB -7.6%) vs baseline: +4.9%

✅ 1-count-metrics-100-times

Time: ✅ 216.151µs (SLO: <250.000µs 📉 -13.5%) vs baseline: +0.9%

Memory: ✅ 31.418MB (SLO: <34.000MB -7.6%) vs baseline: +4.5%

✅ 1-distribution-metric-1-times

Time: ✅ 3.372µs (SLO: <20.000µs 📉 -83.1%) vs baseline: 📈 +13.0%

Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%) vs baseline: +4.9%

✅ 1-distribution-metrics-100-times

Time: ✅ 192.907µs (SLO: <220.000µs 📉 -12.3%) vs baseline: +0.2%

Memory: ✅ 31.379MB (SLO: <34.000MB -7.7%) vs baseline: +4.6%

✅ 1-gauge-metric-1-times

Time: ✅ 2.132µs (SLO: <20.000µs 📉 -89.3%) vs baseline: +1.7%

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +5.0%

✅ 1-gauge-metrics-100-times

Time: ✅ 124.669µs (SLO: <150.000µs 📉 -16.9%) vs baseline: -0.1%

Memory: ✅ 31.438MB (SLO: <34.000MB -7.5%) vs baseline: +4.9%

✅ 1-rate-metric-1-times

Time: ✅ 3.486µs (SLO: <20.000µs 📉 -82.6%) vs baseline: 📈 +10.9%

Memory: ✅ 31.438MB (SLO: <34.000MB -7.5%) vs baseline: +5.1%

✅ 1-rate-metrics-100-times

Time: ✅ 215.216µs (SLO: <250.000µs 📉 -13.9%) vs baseline: +0.5%

Memory: ✅ 31.398MB (SLO: <34.000MB -7.7%) vs baseline: +4.5%

✅ 100-count-metrics-100-times

Time: ✅ 22.390ms (SLO: <23.500ms -4.7%) vs baseline: +4.3%

Memory: ✅ 31.438MB (SLO: <34.000MB -7.5%) vs baseline: +4.8%

✅ 100-distribution-metrics-100-times

Time: ✅ 2.017ms (SLO: <2.250ms 📉 -10.4%) vs baseline: +1.6%

Memory: ✅ 31.438MB (SLO: <34.000MB -7.5%) vs baseline: +4.7%

✅ 100-gauge-metrics-100-times

Time: ✅ 1.268ms (SLO: <1.550ms 📉 -18.2%) vs baseline: -0.1%

Memory: ✅ 31.477MB (SLO: <34.000MB -7.4%) vs baseline: +5.2%

✅ 100-rate-metrics-100-times

Time: ✅ 2.292ms (SLO: <2.550ms 📉 -10.1%) vs baseline: +3.1%

Memory: ✅ 31.418MB (SLO: <34.000MB -7.6%) vs baseline: +4.5%

✅ flush-1-metric

Time: ✅ 4.383µs (SLO: <20.000µs 📉 -78.1%) vs baseline: +3.8%

Memory: ✅ 31.831MB (SLO: <34.000MB -6.4%) vs baseline: +5.4%

✅ flush-100-metrics

Time: ✅ 183.659µs (SLO: <250.000µs 📉 -26.5%) vs baseline: -0.3%

Memory: ✅ 31.850MB (SLO: <34.000MB -6.3%) vs baseline: +5.1%

✅ flush-1000-metrics

Time: ✅ 2.205ms (SLO: <2.500ms 📉 -11.8%) vs baseline: -0.5%

Memory: ✅ 32.539MB (SLO: <34.500MB -5.7%) vs baseline: +4.9%

🟡 Near SLO Breach (5 suites)
🟡 djangosimple - 26/26

✅ appsec

Time: ✅ 20.501ms (SLO: <22.300ms -8.1%) vs baseline: ~same

Memory: ✅ 64.546MB (SLO: <66.000MB -2.2%) vs baseline: +5.0%

✅ exception-replay-enabled

Time: ✅ 1.348ms (SLO: <1.450ms -7.0%) vs baseline: +0.4%

Memory: ✅ 63.472MB (SLO: <66.000MB -3.8%) vs baseline: +4.7%

✅ iast

Time: ✅ 20.503ms (SLO: <22.250ms -7.9%) vs baseline: ~same

Memory: ✅ 64.527MB (SLO: <66.000MB -2.2%) vs baseline: +4.9%

✅ profiler

Time: ✅ 15.237ms (SLO: <16.550ms -7.9%) vs baseline: +0.4%

Memory: ✅ 52.868MB (SLO: <53.500MB 🟡 -1.2%) vs baseline: +4.7%

✅ span-code-origin

Time: ✅ 26.148ms (SLO: <28.200ms -7.3%) vs baseline: -0.2%

Memory: ✅ 66.645MB (SLO: <68.500MB -2.7%) vs baseline: +5.0%

✅ tracer

Time: ✅ 20.503ms (SLO: <21.750ms -5.7%) vs baseline: -0.2%

Memory: ✅ 64.507MB (SLO: <66.000MB -2.3%) vs baseline: +4.8%

✅ tracer-and-profiler

Time: ✅ 22.163ms (SLO: <23.500ms -5.7%) vs baseline: +0.4%

Memory: ✅ 65.751MB (SLO: <67.000MB 🟡 -1.9%) vs baseline: +5.0%

✅ tracer-dont-create-db-spans

Time: ✅ 19.350ms (SLO: <21.500ms 📉 -10.0%) vs baseline: -0.4%

Memory: ✅ 64.458MB (SLO: <66.000MB -2.3%) vs baseline: +4.7%

✅ tracer-native

Time: ✅ 20.469ms (SLO: <21.750ms -5.9%) vs baseline: ~same

Memory: ✅ 65.744MB (SLO: <66.000MB 🟡 -0.4%) vs baseline: +4.8%

✅ tracer-no-caches

Time: ✅ 18.446ms (SLO: <19.650ms -6.1%) vs baseline: -0.3%

Memory: ✅ 64.464MB (SLO: <66.000MB -2.3%) vs baseline: +4.8%

✅ tracer-no-databases

Time: ✅ 18.848ms (SLO: <20.100ms -6.2%) vs baseline: -0.3%

Memory: ✅ 64.113MB (SLO: <66.000MB -2.9%) vs baseline: +4.9%

✅ tracer-no-middleware

Time: ✅ 20.193ms (SLO: <21.500ms -6.1%) vs baseline: ~same

Memory: ✅ 64.507MB (SLO: <66.000MB -2.3%) vs baseline: +4.9%

✅ tracer-no-templates

Time: ✅ 20.356ms (SLO: <22.000ms -7.5%) vs baseline: +0.3%

Memory: ✅ 64.484MB (SLO: <66.000MB -2.3%) vs baseline: +4.9%

🟡 errortrackingdjangosimple - 6/6

✅ errortracking-enabled-all

Time: ✅ 18.058ms (SLO: <19.850ms -9.0%) vs baseline: ~same

Memory: ✅ 64.423MB (SLO: <65.500MB 🟡 -1.6%) vs baseline: +4.7%

✅ errortracking-enabled-user

Time: ✅ 18.069ms (SLO: <19.400ms -6.9%) vs baseline: ~same

Memory: ✅ 64.404MB (SLO: <65.500MB 🟡 -1.7%) vs baseline: +4.8%

✅ tracer-enabled

Time: ✅ 18.252ms (SLO: <19.450ms -6.2%) vs baseline: +1.0%

Memory: ✅ 64.484MB (SLO: <65.500MB 🟡 -1.6%) vs baseline: +5.0%

🟡 flasksimple - 17/17

✅ appsec-get

Time: ✅ 4.575ms (SLO: <4.750ms -3.7%) vs baseline: -0.2%

Memory: ✅ 62.108MB (SLO: <64.500MB -3.7%) vs baseline: +4.7%

✅ appsec-post

Time: ✅ 6.575ms (SLO: <6.750ms -2.6%) vs baseline: ~same

Memory: ✅ 62.344MB (SLO: <64.500MB -3.3%) vs baseline: +4.9%

✅ appsec-telemetry

Time: ✅ 4.574ms (SLO: <4.750ms -3.7%) vs baseline: ~same

Memory: ✅ 62.010MB (SLO: <64.500MB -3.9%) vs baseline: +4.5%

✅ debugger

Time: ✅ 1.855ms (SLO: <2.000ms -7.2%) vs baseline: ~same

Memory: ✅ 44.709MB (SLO: <45.000MB 🟡 -0.6%) vs baseline: +4.7%

✅ iast-get

Time: ✅ 1.858ms (SLO: <2.000ms -7.1%) vs baseline: -0.2%

Memory: ✅ 41.642MB (SLO: <49.000MB 📉 -15.0%) vs baseline: +4.8%

✅ profiler

Time: ✅ 1.915ms (SLO: <2.100ms -8.8%) vs baseline: -0.4%

Memory: ✅ 44.355MB (SLO: <46.500MB -4.6%) vs baseline: +4.6%

✅ tracer

Time: ✅ 3.368ms (SLO: <3.650ms -7.7%) vs baseline: -0.3%

Memory: ✅ 51.413MB (SLO: <53.500MB -3.9%) vs baseline: +4.8%

✅ tracer-native

Time: ✅ 3.372ms (SLO: <3.650ms -7.6%) vs baseline: ~same

Memory: ✅ 52.671MB (SLO: <53.500MB 🟡 -1.5%) vs baseline: +4.7%

🟡 flasksqli - 6/6

✅ appsec-enabled

Time: ✅ 3.945ms (SLO: <4.200ms -6.1%) vs baseline: -0.1%

Memory: ✅ 62.374MB (SLO: <66.000MB -5.5%) vs baseline: +5.0%

✅ iast-enabled

Time: ✅ 2.523ms (SLO: <2.800ms -9.9%) vs baseline: +0.3%

Memory: ✅ 58.168MB (SLO: <59.000MB 🟡 -1.4%) vs baseline: +4.9%

✅ tracer-enabled

Time: ✅ 2.078ms (SLO: <2.250ms -7.7%) vs baseline: +0.1%

Memory: ✅ 51.263MB (SLO: <53.500MB -4.2%) vs baseline: +4.8%

🟡 otelspan - 22/22

✅ add-event

Time: ✅ 45.036ms (SLO: <47.150ms -4.5%) vs baseline: -0.6%

Memory: ✅ 44.655MB (SLO: <46.500MB -4.0%) vs baseline: +5.0%

✅ add-metrics

Time: ✅ 322.249ms (SLO: <344.800ms -6.5%) vs baseline: +0.7%

Memory: ✅ 554.287MB (SLO: <562.000MB 🟡 -1.4%) vs baseline: +5.0%

✅ add-tags

Time: ✅ 293.824ms (SLO: <314.000ms -6.4%) vs baseline: +0.8%

Memory: ✅ 554.267MB (SLO: <563.500MB 🟡 -1.6%) vs baseline: +4.9%

✅ get-context

Time: ✅ 82.949ms (SLO: <92.350ms 📉 -10.2%) vs baseline: ~same

Memory: ✅ 39.725MB (SLO: <46.500MB 📉 -14.6%) vs baseline: +4.8%

✅ is-recording

Time: ✅ 42.739ms (SLO: <44.500ms -4.0%) vs baseline: -0.4%

Memory: ✅ 43.976MB (SLO: <46.500MB -5.4%) vs baseline: +4.7%

✅ record-exception

Time: ✅ 61.751ms (SLO: <67.650ms -8.7%) vs baseline: ~same

Memory: ✅ 40.079MB (SLO: <46.500MB 📉 -13.8%) vs baseline: +5.1%

✅ set-status

Time: ✅ 48.639ms (SLO: <50.400ms -3.5%) vs baseline: -0.8%

Memory: ✅ 44.032MB (SLO: <46.500MB -5.3%) vs baseline: +5.0%

✅ start

Time: ✅ 41.971ms (SLO: <43.450ms -3.4%) vs baseline: -0.9%

Memory: ✅ 44.016MB (SLO: <46.500MB -5.3%) vs baseline: +4.8%

✅ start-finish

Time: ✅ 82.100ms (SLO: <88.000ms -6.7%) vs baseline: -0.3%

Memory: ✅ 33.935MB (SLO: <46.500MB 📉 -27.0%) vs baseline: +4.6%

✅ start-finish-telemetry

Time: ✅ 83.819ms (SLO: <89.000ms -5.8%) vs baseline: +0.2%

Memory: ✅ 34.013MB (SLO: <46.500MB 📉 -26.9%) vs baseline: +5.0%

✅ update-name

Time: ✅ 44.036ms (SLO: <45.150ms -2.5%) vs baseline: -0.7%

Memory: ✅ 44.369MB (SLO: <46.500MB -4.6%) vs baseline: +4.9%

⚠️ Unstable Tests (1 suite)
⚠️ coreapiscenario - 12/12 (2 unstable)

⚠️ context_with_data_listeners

Time: ⚠️ 13.477µs (SLO: <20.000µs 📉 -32.6%) vs baseline: +0.6%

Memory: ✅ 31.418MB (SLO: <33.500MB -6.2%) vs baseline: +5.0%

✅ context_with_data_no_listeners

Time: ✅ 3.411µs (SLO: <10.000µs 📉 -65.9%) vs baseline: -0.4%

Memory: ✅ 31.457MB (SLO: <33.500MB -6.1%) vs baseline: +5.1%

⚠️ context_with_data_only_all_listeners

Time: ⚠️ 13.410µs (SLO: <20.000µs 📉 -32.9%) vs baseline: ~same

Memory: ✅ 31.438MB (SLO: <33.500MB -6.2%) vs baseline: +4.9%

✅ get_item_exists

Time: ✅ 0.582µs (SLO: <10.000µs 📉 -94.2%) vs baseline: -0.4%

Memory: ✅ 31.457MB (SLO: <33.500MB -6.1%) vs baseline: +5.2%

✅ get_item_missing

Time: ✅ 0.639µs (SLO: <10.000µs 📉 -93.6%) vs baseline: -1.2%

Memory: ✅ 31.418MB (SLO: <33.500MB -6.2%) vs baseline: +5.0%

✅ set_item

Time: ✅ 24.148µs (SLO: <30.000µs 📉 -19.5%) vs baseline: -1.0%

Memory: ✅ 31.438MB (SLO: <33.500MB -6.2%) vs baseline: +4.9%

✅ All Tests Passing (16 suites)
✅ errortrackingflasksqli - 6/6

✅ errortracking-enabled-all

Time: ✅ 2.099ms (SLO: <2.300ms -8.8%) vs baseline: +0.2%

Memory: ✅ 51.290MB (SLO: <53.500MB -4.1%) vs baseline: +4.8%

✅ errortracking-enabled-user

Time: ✅ 2.097ms (SLO: <2.250ms -6.8%) vs baseline: +0.6%

Memory: ✅ 51.312MB (SLO: <53.500MB -4.1%) vs baseline: +4.9%

✅ tracer-enabled

Time: ✅ 2.118ms (SLO: <2.300ms -7.9%) vs baseline: +1.2%

Memory: ✅ 51.289MB (SLO: <53.500MB -4.1%) vs baseline: +4.9%

✅ httppropagationextract - 60/60

✅ all_styles_all_headers

Time: ✅ 83.180µs (SLO: <100.000µs 📉 -16.8%) vs baseline: +2.3%

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%) vs baseline: +4.9%

✅ b3_headers

Time: ✅ 14.376µs (SLO: <20.000µs 📉 -28.1%) vs baseline: +1.2%

Memory: ✅ 31.477MB (SLO: <33.500MB -6.0%) vs baseline: +4.6%

✅ b3_single_headers

Time: ✅ 13.373µs (SLO: <20.000µs 📉 -33.1%) vs baseline: +0.5%

Memory: ✅ 31.536MB (SLO: <33.500MB -5.9%) vs baseline: +5.0%

✅ datadog_tracecontext_tracestate_not_propagated_on_trace_id_no_match

Time: ✅ 64.556µs (SLO: <80.000µs 📉 -19.3%) vs baseline: ~same

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%) vs baseline: +4.8%

✅ datadog_tracecontext_tracestate_propagated_on_trace_id_match

Time: ✅ 66.886µs (SLO: <80.000µs 📉 -16.4%) vs baseline: +0.4%

Memory: ✅ 31.536MB (SLO: <33.500MB -5.9%) vs baseline: +4.9%

✅ empty_headers

Time: ✅ 1.615µs (SLO: <10.000µs 📉 -83.8%) vs baseline: +1.5%

Memory: ✅ 31.556MB (SLO: <33.500MB -5.8%) vs baseline: +4.9%

✅ full_t_id_datadog_headers

Time: ✅ 22.821µs (SLO: <30.000µs 📉 -23.9%) vs baseline: -1.0%

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%) vs baseline: +4.8%

✅ invalid_priority_header

Time: ✅ 6.549µs (SLO: <10.000µs 📉 -34.5%) vs baseline: +0.4%

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +5.0%

✅ invalid_span_id_header

Time: ✅ 6.509µs (SLO: <10.000µs 📉 -34.9%) vs baseline: +0.3%

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +4.9%

✅ invalid_tags_header

Time: ✅ 6.564µs (SLO: <10.000µs 📉 -34.4%) vs baseline: +0.3%

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +4.9%

✅ invalid_trace_id_header

Time: ✅ 6.504µs (SLO: <10.000µs 📉 -35.0%) vs baseline: ~same

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +4.9%

✅ large_header_no_matches

Time: ✅ 27.673µs (SLO: <30.000µs -7.8%) vs baseline: +0.4%

Memory: ✅ 31.575MB (SLO: <33.500MB -5.7%) vs baseline: +5.0%

✅ large_valid_headers_all

Time: ✅ 28.728µs (SLO: <40.000µs 📉 -28.2%) vs baseline: +0.3%

Memory: ✅ 31.536MB (SLO: <33.500MB -5.9%) vs baseline: +4.9%

✅ medium_header_no_matches

Time: ✅ 9.890µs (SLO: <20.000µs 📉 -50.5%) vs baseline: +0.4%

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +4.9%

✅ medium_valid_headers_all

Time: ✅ 11.327µs (SLO: <20.000µs 📉 -43.4%) vs baseline: +0.5%

Memory: ✅ 31.477MB (SLO: <33.500MB -6.0%) vs baseline: +4.7%

✅ none_propagation_style

Time: ✅ 1.706µs (SLO: <10.000µs 📉 -82.9%) vs baseline: +0.5%

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%) vs baseline: +4.8%

✅ tracecontext_headers

Time: ✅ 35.330µs (SLO: <40.000µs 📉 -11.7%) vs baseline: +2.7%

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%) vs baseline: +4.6%

✅ valid_headers_all

Time: ✅ 6.505µs (SLO: <10.000µs 📉 -35.0%) vs baseline: ~same

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +5.1%

✅ valid_headers_basic

Time: ✅ 6.083µs (SLO: <10.000µs 📉 -39.2%) vs baseline: ~same

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +4.8%

✅ wsgi_empty_headers

Time: ✅ 1.597µs (SLO: <10.000µs 📉 -84.0%) vs baseline: ~same

Memory: ✅ 31.536MB (SLO: <33.500MB -5.9%) vs baseline: +4.7%

✅ wsgi_invalid_priority_header

Time: ✅ 6.574µs (SLO: <10.000µs 📉 -34.3%) vs baseline: +0.7%

Memory: ✅ 31.536MB (SLO: <33.500MB -5.9%) vs baseline: +4.8%

✅ wsgi_invalid_span_id_header

Time: ✅ 1.590µs (SLO: <10.000µs 📉 -84.1%) vs baseline: +0.5%

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +5.1%

✅ wsgi_invalid_tags_header

Time: ✅ 6.635µs (SLO: <10.000µs 📉 -33.7%) vs baseline: +1.6%

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%) vs baseline: +4.9%

✅ wsgi_invalid_trace_id_header

Time: ✅ 6.595µs (SLO: <10.000µs 📉 -34.1%) vs baseline: +0.3%

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +4.7%

✅ wsgi_large_header_no_matches

Time: ✅ 28.813µs (SLO: <40.000µs 📉 -28.0%) vs baseline: +0.7%

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +4.7%

✅ wsgi_large_valid_headers_all

Time: ✅ 29.978µs (SLO: <40.000µs 📉 -25.1%) vs baseline: +0.5%

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +4.9%

✅ wsgi_medium_header_no_matches

Time: ✅ 10.059µs (SLO: <20.000µs 📉 -49.7%) vs baseline: -0.1%

Memory: ✅ 31.457MB (SLO: <33.500MB -6.1%) vs baseline: +4.6%

✅ wsgi_medium_valid_headers_all

Time: ✅ 11.489µs (SLO: <20.000µs 📉 -42.6%) vs baseline: +0.4%

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%) vs baseline: +4.9%

✅ wsgi_valid_headers_all

Time: ✅ 6.582µs (SLO: <10.000µs 📉 -34.2%) vs baseline: ~same

Memory: ✅ 31.556MB (SLO: <33.500MB -5.8%) vs baseline: +4.8%

✅ wsgi_valid_headers_basic

Time: ✅ 6.087µs (SLO: <10.000µs 📉 -39.1%) vs baseline: -0.4%

Memory: ✅ 31.556MB (SLO: <33.500MB -5.8%) vs baseline: +5.1%

✅ httppropagationinject - 16/16

✅ ids_only

Time: ✅ 22.487µs (SLO: <30.000µs 📉 -25.0%) vs baseline: +2.5%

Memory: ✅ 31.477MB (SLO: <33.500MB -6.0%) vs baseline: +4.8%

✅ with_all

Time: ✅ 29.412µs (SLO: <40.000µs 📉 -26.5%) vs baseline: +0.1%

Memory: ✅ 31.477MB (SLO: <33.500MB -6.0%) vs baseline: +4.7%

✅ with_dd_origin

Time: ✅ 26.479µs (SLO: <30.000µs 📉 -11.7%) vs baseline: +2.9%

Memory: ✅ 31.536MB (SLO: <33.500MB -5.9%) vs baseline: +4.9%

✅ with_priority_and_origin

Time: ✅ 25.283µs (SLO: <40.000µs 📉 -36.8%) vs baseline: +0.3%

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%) vs baseline: +4.9%

✅ with_sampling_priority

Time: ✅ 22.711µs (SLO: <30.000µs 📉 -24.3%) vs baseline: +4.0%

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +4.9%

✅ with_tags

Time: ✅ 28.531µs (SLO: <40.000µs 📉 -28.7%) vs baseline: +4.0%

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%) vs baseline: +4.9%

✅ with_tags_invalid

Time: ✅ 29.686µs (SLO: <40.000µs 📉 -25.8%) vs baseline: +3.1%

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +4.9%

✅ with_tags_max_size

Time: ✅ 27.812µs (SLO: <40.000µs 📉 -30.5%) vs baseline: -0.5%

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%) vs baseline: +4.7%

✅ iast_aspects - 40/40

✅ re_expand_aspect

Time: ✅ 31.741µs (SLO: <40.000µs 📉 -20.6%) vs baseline: ~same

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.9%

✅ re_expand_noaspect

Time: ✅ 29.740µs (SLO: <40.000µs 📉 -25.7%) vs baseline: +3.7%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +4.8%

✅ re_findall_aspect

Time: ✅ 3.888µs (SLO: <10.000µs 📉 -61.1%) vs baseline: +0.6%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +4.9%

✅ re_findall_noaspect

Time: ✅ 1.402µs (SLO: <10.000µs 📉 -86.0%) vs baseline: ~same

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.0%

✅ re_finditer_aspect

Time: ✅ 4.702µs (SLO: <10.000µs 📉 -53.0%) vs baseline: +5.6%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.9%

✅ re_finditer_noaspect

Time: ✅ 1.411µs (SLO: <10.000µs 📉 -85.9%) vs baseline: +0.7%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.7%

✅ re_fullmatch_aspect

Time: ✅ 2.719µs (SLO: <10.000µs 📉 -72.8%) vs baseline: +0.8%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.0%

✅ re_fullmatch_noaspect

Time: ✅ 1.294µs (SLO: <10.000µs 📉 -87.1%) vs baseline: ~same

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.7%

✅ re_group_aspect

Time: ✅ 2.919µs (SLO: <10.000µs 📉 -70.8%) vs baseline: -1.0%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.9%

✅ re_group_noaspect

Time: ✅ 1.590µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -0.7%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.0%

✅ re_groups_aspect

Time: ✅ 3.055µs (SLO: <10.000µs 📉 -69.5%) vs baseline: +0.5%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.8%

✅ re_groups_noaspect

Time: ✅ 1.689µs (SLO: <10.000µs 📉 -83.1%) vs baseline: -0.4%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.7%

✅ re_match_aspect

Time: ✅ 2.724µs (SLO: <10.000µs 📉 -72.8%) vs baseline: ~same

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +4.9%

✅ re_match_noaspect

Time: ✅ 1.295µs (SLO: <10.000µs 📉 -87.0%) vs baseline: -0.4%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.0%

✅ re_search_aspect

Time: ✅ 2.586µs (SLO: <10.000µs 📉 -74.1%) vs baseline: +0.7%

Memory: ✅ 37.552MB (SLO: <39.000MB -3.7%) vs baseline: +5.1%

✅ re_search_noaspect

Time: ✅ 1.192µs (SLO: <10.000µs 📉 -88.1%) vs baseline: -0.7%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.7%

✅ re_sub_aspect

Time: ✅ 3.384µs (SLO: <10.000µs 📉 -66.2%) vs baseline: ~same

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.7%

✅ re_sub_noaspect

Time: ✅ 1.532µs (SLO: <10.000µs 📉 -84.7%) vs baseline: +0.7%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.1%

✅ re_subn_aspect

Time: ✅ 3.678µs (SLO: <10.000µs 📉 -63.2%) vs baseline: +0.4%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.1%

✅ re_subn_noaspect

Time: ✅ 1.606µs (SLO: <10.000µs 📉 -83.9%) vs baseline: -0.8%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.0%

✅ iastaspectsospath - 24/24

✅ ospathbasename_aspect

Time: ✅ 4.153µs (SLO: <10.000µs 📉 -58.5%) vs baseline: -1.0%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +4.9%

✅ ospathbasename_noaspect

Time: ✅ 1.090µs (SLO: <10.000µs 📉 -89.1%) vs baseline: +1.5%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.0%

✅ ospathjoin_aspect

Time: ✅ 6.045µs (SLO: <10.000µs 📉 -39.6%) vs baseline: +0.5%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +4.8%

✅ ospathjoin_noaspect

Time: ✅ 2.293µs (SLO: <10.000µs 📉 -77.1%) vs baseline: -0.4%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.9%

✅ ospathnormcase_aspect

Time: ✅ 3.753µs (SLO: <10.000µs 📉 -62.5%) vs baseline: +9.9%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.8%

✅ ospathnormcase_noaspect

Time: ✅ 0.566µs (SLO: <10.000µs 📉 -94.3%) vs baseline: +0.2%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.0%

✅ ospathsplit_aspect

Time: ✅ 4.712µs (SLO: <10.000µs 📉 -52.9%) vs baseline: -0.9%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.9%

✅ ospathsplit_noaspect

Time: ✅ 1.597µs (SLO: <10.000µs 📉 -84.0%) vs baseline: +0.8%

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +4.9%

✅ ospathsplitdrive_aspect

Time: ✅ 3.627µs (SLO: <10.000µs 📉 -63.7%) vs baseline: +0.4%

Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +4.5%

✅ ospathsplitdrive_noaspect

Time: ✅ 0.693µs (SLO: <10.000µs 📉 -93.1%) vs baseline: -0.5%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.0%

✅ ospathsplitext_aspect

Time: ✅ 4.444µs (SLO: <10.000µs 📉 -55.6%) vs baseline: -0.3%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.7%

✅ ospathsplitext_noaspect

Time: ✅ 1.374µs (SLO: <10.000µs 📉 -86.3%) vs baseline: -0.7%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +4.8%

✅ iastaspectssplit - 12/12

✅ rsplit_aspect

Time: ✅ 1.429µs (SLO: <10.000µs 📉 -85.7%) vs baseline: +6.2%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.0%

✅ rsplit_noaspect

Time: ✅ 0.583µs (SLO: <10.000µs 📉 -94.2%) vs baseline: +0.9%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.5%

✅ split_aspect

Time: ✅ 1.403µs (SLO: <10.000µs 📉 -86.0%) vs baseline: +5.9%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.7%

✅ split_noaspect

Time: ✅ 0.570µs (SLO: <10.000µs 📉 -94.3%) vs baseline: +0.1%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.0%

✅ splitlines_aspect

Time: ✅ 1.327µs (SLO: <10.000µs 📉 -86.7%) vs baseline: -1.1%

Memory: ✅ 37.532MB (SLO: <39.000MB -3.8%) vs baseline: +5.1%

✅ splitlines_noaspect

Time: ✅ 0.581µs (SLO: <10.000µs 📉 -94.2%) vs baseline: -0.3%

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +4.9%

✅ iastpropagation - 8/8

✅ no-propagation

Time: ✅ 49.137µs (SLO: <60.000µs 📉 -18.1%) vs baseline: +0.9%

Memory: ✅ 37.021MB (SLO: <39.000MB -5.1%) vs baseline: +4.7%

✅ propagation_enabled

Time: ✅ 151.137µs (SLO: <160.000µs -5.5%) vs baseline: +0.5%

Memory: ✅ 37.080MB (SLO: <39.000MB -4.9%) vs baseline: +4.8%

✅ propagation_enabled_100

Time: ✅ 1.625ms (SLO: <1.800ms -9.7%) vs baseline: -0.1%

Memory: ✅ 37.061MB (SLO: <39.000MB -5.0%) vs baseline: +4.8%

✅ propagation_enabled_1000

Time: ✅ 29.455ms (SLO: <30.550ms -3.6%) vs baseline: -0.2%

Memory: ✅ 37.021MB (SLO: <39.000MB -5.1%) vs baseline: +4.8%

✅ otelsdkspan - 24/24

✅ add-event

Time: ✅ 40.470ms (SLO: <42.000ms -3.6%) vs baseline: -0.4%

Memory: ✅ 34.347MB (SLO: <39.000MB 📉 -11.9%) vs baseline: +5.0%

✅ add-link

Time: ✅ 36.496ms (SLO: <38.550ms -5.3%) vs baseline: ~same

Memory: ✅ 34.328MB (SLO: <39.000MB 📉 -12.0%) vs baseline: +5.2%

✅ add-metrics

Time: ✅ 220.267ms (SLO: <232.000ms -5.1%) vs baseline: +0.5%

Memory: ✅ 34.288MB (SLO: <39.000MB 📉 -12.1%) vs baseline: +4.9%

✅ add-tags

Time: ✅ 212.229ms (SLO: <221.600ms -4.2%) vs baseline: +0.3%

Memory: ✅ 34.328MB (SLO: <39.000MB 📉 -12.0%) vs baseline: +5.1%

✅ get-context

Time: ✅ 29.229ms (SLO: <31.300ms -6.6%) vs baseline: -0.3%

Memory: ✅ 34.249MB (SLO: <39.000MB 📉 -12.2%) vs baseline: +4.6%

✅ is-recording

Time: ✅ 29.198ms (SLO: <31.000ms -5.8%) vs baseline: ~same

Memory: ✅ 34.308MB (SLO: <39.000MB 📉 -12.0%) vs baseline: +4.7%

✅ record-exception

Time: ✅ 63.413ms (SLO: <65.850ms -3.7%) vs baseline: ~same

Memory: ✅ 34.288MB (SLO: <39.000MB 📉 -12.1%) vs baseline: +4.9%

✅ set-status

Time: ✅ 31.869ms (SLO: <34.150ms -6.7%) vs baseline: -0.8%

Memory: ✅ 34.288MB (SLO: <39.000MB 📉 -12.1%) vs baseline: +4.9%

✅ start

Time: ✅ 28.773ms (SLO: <30.150ms -4.6%) vs baseline: +0.1%

Memory: ✅ 34.269MB (SLO: <39.000MB 📉 -12.1%) vs baseline: +4.9%

✅ start-finish

Time: ✅ 34.274ms (SLO: <35.350ms -3.0%) vs baseline: +0.3%

Memory: ✅ 34.288MB (SLO: <39.000MB 📉 -12.1%) vs baseline: +5.0%

✅ start-finish-telemetry

Time: ✅ 34.142ms (SLO: <35.450ms -3.7%) vs baseline: -0.3%

Memory: ✅ 34.288MB (SLO: <39.000MB 📉 -12.1%) vs baseline: +4.9%

✅ update-name

Time: ✅ 31.155ms (SLO: <33.400ms -6.7%) vs baseline: +0.2%

Memory: ✅ 34.288MB (SLO: <39.000MB 📉 -12.1%) vs baseline: +4.9%

✅ packagespackageforrootmodulemapping - 4/4

✅ cache_off

Time: ✅ 338.835ms (SLO: <354.300ms -4.4%) vs baseline: -0.7%

Memory: ✅ 36.780MB (SLO: <40.000MB -8.0%) vs baseline: +4.3%

✅ cache_on

Time: ✅ 0.388µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +1.8%

Memory: ✅ 35.353MB (SLO: <39.000MB -9.4%) vs baseline: +5.4%

✅ packagesupdateimporteddependencies - 24/24

✅ import_many

Time: ✅ 155.446µs (SLO: <170.000µs -8.6%) vs baseline: -0.1%

Memory: ✅ 35.955MB (SLO: <38.500MB -6.6%) vs baseline: +3.9%

✅ import_many_cached

Time: ✅ 121.331µs (SLO: <130.000µs -6.7%) vs baseline: -0.7%

Memory: ✅ 35.738MB (SLO: <38.500MB -7.2%) vs baseline: +4.5%

✅ import_many_stdlib

Time: ✅ 1.617ms (SLO: <1.750ms -7.6%) vs baseline: +0.1%

Memory: ✅ 36.062MB (SLO: <38.500MB -6.3%) vs baseline: +5.1%

✅ import_many_stdlib_cached

Time: ✅ 0.964ms (SLO: <1.100ms 📉 -12.4%) vs baseline: -0.3%

Memory: ✅ 36.065MB (SLO: <38.500MB -6.3%) vs baseline: +4.4%

✅ import_many_unknown

Time: ✅ 829.352µs (SLO: <890.000µs -6.8%) vs baseline: -0.3%

Memory: ✅ 35.887MB (SLO: <38.500MB -6.8%) vs baseline: +3.6%

✅ import_many_unknown_cached

Time: ✅ 787.368µs (SLO: <870.000µs -9.5%) vs baseline: -0.5%

Memory: ✅ 36.185MB (SLO: <38.500MB -6.0%) vs baseline: +4.7%

✅ import_one

Time: ✅ 19.957µs (SLO: <30.000µs 📉 -33.5%) vs baseline: +1.3%

Memory: ✅ 36.014MB (SLO: <39.000MB -7.7%) vs baseline: +4.8%

✅ import_one_cache

Time: ✅ 6.304µs (SLO: <10.000µs 📉 -37.0%) vs baseline: +0.2%

Memory: ✅ 35.905MB (SLO: <38.500MB -6.7%) vs baseline: +4.1%

✅ import_one_stdlib

Time: ✅ 18.731µs (SLO: <20.000µs -6.3%) vs baseline: +0.3%

Memory: ✅ 36.024MB (SLO: <38.500MB -6.4%) vs baseline: +4.5%

✅ import_one_stdlib_cache

Time: ✅ 6.279µs (SLO: <10.000µs 📉 -37.2%) vs baseline: ~same

Memory: ✅ 36.054MB (SLO: <38.500MB -6.4%) vs baseline: +5.6%

✅ import_one_unknown

Time: ✅ 45.402µs (SLO: <50.000µs -9.2%) vs baseline: ~same

Memory: ✅ 35.922MB (SLO: <38.500MB -6.7%) vs baseline: +4.0%

✅ import_one_unknown_cache

Time: ✅ 6.310µs (SLO: <10.000µs 📉 -36.9%) vs baseline: +1.3%

Memory: ✅ 35.944MB (SLO: <38.500MB -6.6%) vs baseline: +5.4%

✅ ratelimiter - 12/12

✅ defaults

Time: ✅ 2.350µs (SLO: <10.000µs 📉 -76.5%) vs baseline: +0.8%

Memory: ✅ 31.044MB (SLO: <34.000MB -8.7%) vs baseline: +4.7%

✅ high_rate_limit

Time: ✅ 2.410µs (SLO: <10.000µs 📉 -75.9%) vs baseline: -0.2%

Memory: ✅ 31.103MB (SLO: <34.000MB -8.5%) vs baseline: +5.0%

✅ long_window

Time: ✅ 2.357µs (SLO: <10.000µs 📉 -76.4%) vs baseline: +0.3%

Memory: ✅ 31.103MB (SLO: <34.000MB -8.5%) vs baseline: +5.0%

✅ low_rate_limit

Time: ✅ 2.370µs (SLO: <10.000µs 📉 -76.3%) vs baseline: +0.7%

Memory: ✅ 31.103MB (SLO: <34.000MB -8.5%) vs baseline: +4.9%

✅ no_rate_limit

Time: ✅ 0.837µs (SLO: <10.000µs 📉 -91.6%) vs baseline: +0.8%

Memory: ✅ 31.025MB (SLO: <34.000MB -8.8%) vs baseline: +4.8%

✅ short_window

Time: ✅ 2.495µs (SLO: <10.000µs 📉 -75.1%) vs baseline: ~same

Memory: ✅ 31.025MB (SLO: <34.000MB -8.8%) vs baseline: +4.7%

✅ recursivecomputation - 8/8

✅ deep

Time: ✅ 308.531ms (SLO: <320.950ms -3.9%) vs baseline: -0.3%

Memory: ✅ 32.657MB (SLO: <34.500MB -5.3%) vs baseline: +4.8%

✅ deep-profiled

Time: ✅ 326.501ms (SLO: <359.150ms -9.1%) vs baseline: -0.2%

Memory: ✅ 35.232MB (SLO: <39.000MB -9.7%) vs baseline: +4.9%

✅ medium

Time: ✅ 7.067ms (SLO: <7.400ms -4.5%) vs baseline: -0.4%

Memory: ✅ 31.438MB (SLO: <34.000MB -7.5%) vs baseline: +4.7%

✅ shallow

Time: ✅ 0.956ms (SLO: <1.050ms -9.0%) vs baseline: +0.3%

Memory: ✅ 31.418MB (SLO: <34.000MB -7.6%) vs baseline: +4.8%

✅ samplingrules - 8/8

✅ average_match

Time: ✅ 148.312µs (SLO: <290.000µs 📉 -48.9%) vs baseline: -0.2%

Memory: ✅ 31.438MB (SLO: <34.000MB -7.5%) vs baseline: +4.7%

✅ high_match

Time: ✅ 195.013µs (SLO: <480.000µs 📉 -59.4%) vs baseline: -1.3%

Memory: ✅ 31.477MB (SLO: <34.000MB -7.4%) vs baseline: +4.9%

✅ low_match

Time: ✅ 99.772µs (SLO: <120.000µs 📉 -16.9%) vs baseline: +0.5%

Memory: ✅ 632.022MB (SLO: <700.000MB -9.7%) vs baseline: +4.9%

✅ very_low_match

Time: ✅ 2.889ms (SLO: <8.500ms 📉 -66.0%) vs baseline: ~same

Memory: ✅ 69.705MB (SLO: <75.000MB -7.1%) vs baseline: +4.8%

✅ sethttpmeta - 32/32

✅ all-disabled

Time: ✅ 10.620µs (SLO: <20.000µs 📉 -46.9%) vs baseline: -0.4%

Memory: ✅ 31.929MB (SLO: <34.000MB -6.1%) vs baseline: +4.8%

✅ all-enabled

Time: ✅ 40.257µs (SLO: <50.000µs 📉 -19.5%) vs baseline: +0.4%

Memory: ✅ 32.322MB (SLO: <34.000MB -4.9%) vs baseline: +5.1%

✅ collectipvariant_exists

Time: ✅ 40.845µs (SLO: <50.000µs 📉 -18.3%) vs baseline: +0.2%

Memory: ✅ 32.322MB (SLO: <34.000MB -4.9%) vs baseline: +5.1%

✅ no-collectipvariant

Time: ✅ 40.377µs (SLO: <50.000µs 📉 -19.2%) vs baseline: +1.0%

Memory: ✅ 31.968MB (SLO: <34.000MB -6.0%) vs baseline: +4.2%

✅ no-useragentvariant

Time: ✅ 38.882µs (SLO: <50.000µs 📉 -22.2%) vs baseline: +0.3%

Memory: ✅ 32.303MB (SLO: <34.000MB -5.0%) vs baseline: +5.0%

✅ obfuscation-no-query

Time: ✅ 41.020µs (SLO: <50.000µs 📉 -18.0%) vs baseline: +1.2%

Memory: ✅ 31.949MB (SLO: <34.000MB -6.0%) vs baseline: +4.2%

✅ obfuscation-regular-case-explicit-query

Time: ✅ 76.207µs (SLO: <90.000µs 📉 -15.3%) vs baseline: +0.3%

Memory: ✅ 32.342MB (SLO: <34.000MB -4.9%) vs baseline: +4.9%

✅ obfuscation-regular-case-implicit-query

Time: ✅ 76.454µs (SLO: <90.000µs 📉 -15.1%) vs baseline: ~same

Memory: ✅ 32.303MB (SLO: <34.000MB -5.0%) vs baseline: +4.7%

✅ obfuscation-send-querystring-disabled

Time: ✅ 154.089µs (SLO: <170.000µs -9.4%) vs baseline: +0.2%

Memory: ✅ 32.362MB (SLO: <34.500MB -6.2%) vs baseline: +4.9%

✅ obfuscation-worst-case-explicit-query

Time: ✅ 148.613µs (SLO: <160.000µs -7.1%) vs baseline: +0.4%

Memory: ✅ 32.362MB (SLO: <34.500MB -6.2%) vs baseline: +5.0%

✅ obfuscation-worst-case-implicit-query

Time: ✅ 154.570µs (SLO: <170.000µs -9.1%) vs baseline: ~same

Memory: ✅ 32.342MB (SLO: <34.500MB -6.3%) vs baseline: +5.1%

✅ useragentvariant_exists_1

Time: ✅ 39.785µs (SLO: <50.000µs 📉 -20.4%) vs baseline: +0.3%

Memory: ✅ 32.224MB (SLO: <34.000MB -5.2%) vs baseline: +5.0%

✅ useragentvariant_exists_2

Time: ✅ 40.862µs (SLO: <50.000µs 📉 -18.3%) vs baseline: +0.3%

Memory: ✅ 31.929MB (SLO: <34.000MB -6.1%) vs baseline: +4.1%

✅ useragentvariant_exists_3

Time: ✅ 40.138µs (SLO: <50.000µs 📉 -19.7%) vs baseline: ~same

Memory: ✅ 31.949MB (SLO: <34.000MB -6.0%) vs baseline: +4.1%

✅ useragentvariant_not_exists_1

Time: ✅ 39.639µs (SLO: <50.000µs 📉 -20.7%) vs baseline: +0.3%

Memory: ✅ 32.303MB (SLO: <34.000MB -5.0%) vs baseline: +4.9%

✅ useragentvariant_not_exists_2

Time: ✅ 39.739µs (SLO: <50.000µs 📉 -20.5%) vs baseline: +0.8%

Memory: ✅ 32.303MB (SLO: <34.000MB -5.0%) vs baseline: +4.8%

✅ span - 26/26

✅ add-event

Time: ✅ 24.244ms (SLO: <26.200ms -7.5%) vs baseline: ~same

Memory: ✅ 51.087MB (SLO: <53.000MB -3.6%) vs baseline: +5.0%

✅ add-metrics

Time: ✅ 92.192ms (SLO: <98.350ms -6.3%) vs baseline: ~same

Memory: ✅ 606.366MB (SLO: <961.000MB 📉 -36.9%) vs baseline: +4.9%

✅ add-tags

Time: ✅ 149.716ms (SLO: <168.550ms 📉 -11.2%) vs baseline: -0.3%

Memory: ✅ 607.492MB (SLO: <962.500MB 📉 -36.9%) vs baseline: +5.0%

✅ get-context

Time: ✅ 22.352ms (SLO: <23.700ms -5.7%) vs baseline: ~same

Memory: ✅ 49.873MB (SLO: <53.000MB -5.9%) vs baseline: +4.8%

✅ is-recording

Time: ✅ 22.757ms (SLO: <23.900ms -4.8%) vs baseline: +0.2%

Memory: ✅ 49.884MB (SLO: <53.000MB -5.9%) vs baseline: +4.8%

✅ record-exception

Time: ✅ 43.042ms (SLO: <44.500ms -3.3%) vs baseline: +1.3%

Memory: ✅ 42.726MB (SLO: <53.000MB 📉 -19.4%) vs baseline: +4.8%

✅ set-status

Time: ✅ 24.347ms (SLO: <26.000ms -6.4%) vs baseline: +0.4%

Memory: ✅ 49.858MB (SLO: <53.000MB -5.9%) vs baseline: +4.8%

✅ start

Time: ✅ 22.290ms (SLO: <23.500ms -5.2%) vs baseline: +1.0%

Memory: ✅ 49.920MB (SLO: <53.000MB -5.8%) vs baseline: +4.9%

✅ start-finish

Time: ✅ 51.424ms (SLO: <55.500ms -7.3%) vs baseline: -0.2%

Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%) vs baseline: +4.9%

✅ start-finish-telemetry

Time: ✅ 53.272ms (SLO: <58.300ms -8.6%) vs baseline: +0.8%

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +4.9%

✅ start-finish-traceid128

Time: ✅ 55.112ms (SLO: <60.050ms -8.2%) vs baseline: +0.6%

Memory: ✅ 31.418MB (SLO: <34.000MB -7.6%) vs baseline: +4.9%

✅ start-traceid128

Time: ✅ 22.654ms (SLO: <24.600ms -7.9%) vs baseline: +0.8%

Memory: ✅ 49.943MB (SLO: <53.000MB -5.8%) vs baseline: +4.9%

✅ update-name

Time: ✅ 23.108ms (SLO: <24.100ms -4.1%) vs baseline: -0.2%

Memory: ✅ 50.585MB (SLO: <53.000MB -4.6%) vs baseline: +4.9%

✅ tracer - 6/6

✅ large

Time: ✅ 30.855ms (SLO: <32.950ms -6.4%) vs baseline: +0.3%

Memory: ✅ 32.991MB (SLO: <34.500MB -4.4%) vs baseline: +4.9%

✅ medium

Time: ✅ 2.997ms (SLO: <3.200ms -6.3%) vs baseline: +0.5%

Memory: ✅ 31.438MB (SLO: <34.000MB -7.5%) vs baseline: +4.9%

✅ small

Time: ✅ 336.772µs (SLO: <370.000µs -9.0%) vs baseline: -0.6%

Memory: ✅ 31.398MB (SLO: <34.000MB -7.7%) vs baseline: +4.7%

@gnufede gnufede marked this pull request as ready for review September 9, 2025 19:59
@gnufede gnufede requested review from a team as code owners September 9, 2025 19:59
@juanjux
Copy link
Collaborator

juanjux commented Sep 10, 2025

It's really necessary for Any? Since Any includes None.

@gnufede
Copy link
Member Author

gnufede commented Sep 10, 2025

It's really necessary for Any? Since Any includes None.

Explicit is better than implicit.

@gnufede gnufede enabled auto-merge (squash) September 10, 2025 15:11
vitor-de-araujo
vitor-de-araujo approved these changes Sep 10, 2025
View reviewed changes
@juanjux
Copy link
Collaborator

juanjux commented Sep 11, 2025

It's really necessary for Any? Since Any includes None.

Explicit is better than implicit.

Yeah but Any already explicitly includes None and it's threated as such on all the mypy docs:

https://mypy.readthedocs.io/en/stable/kinds_of_types.html#the-any-type

a: Any = None  # Note they don't use a: Optional[Any]

@gnufede
Copy link
Member Author

gnufede commented Sep 11, 2025

It's really necessary for Any? Since Any includes None.

Explicit is better than implicit.

Yeah but Any already explicitly includes None and it's threated as such on all the mypy docs:

mypy.readthedocs.io/en/stable/kinds_of_types.html#the-any-type

a: Any = None  # Note they don't use a: Optional[Any]

OK, you are right, mypy doesn't complain, I personally prefer Optional[Any], but that can be introduced by each of the codeowners if they prefer it.

Also, that reduces the scope of the PR, so I prefer it.

Kyle-Verhoog
Kyle-Verhoog approved these changes Sep 11, 2025
View reviewed changes
@gnufede gnufede merged commit bc05edd into main Sep 11, 2025
592 checks passed
@gnufede gnufede deleted the gnufede/mypy-remove-implicit-optional branch September 11, 2025 16:59
brettlangdon pushed a commit that referenced this pull request Sep 15, 2025
@gnufede @brettlangdon
chore: explicit optionals everywhere (#14535)
d24fa0b 
Code style: This PR changes implicit optionals to explicit ones (in type
annotations)

Read more here:
https://github.com/hauntsaninja/no_implicit_optional?tab=readme-ov-file#whats-going-on

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KowalskiThomas KowalskiThomas KowalskiThomas approved these changes

@juanjux juanjux juanjux approved these changes

@brettlangdon brettlangdon brettlangdon approved these changes

@Kyle-Verhoog Kyle-Verhoog Kyle-Verhoog approved these changes

@christophe-papazian christophe-papazian christophe-papazian approved these changes

@vitor-de-araujo vitor-de-araujo vitor-de-araujo approved these changes

@rachelyangdog rachelyangdog Awaiting requested review from rachelyangdog rachelyangdog was automatically assigned from DataDog/apm-sdk-api-python

@Mariovido Mariovido Awaiting requested review from Mariovido Mariovido is a code owner automatically assigned from DataDog/ci-app-libraries

@P403n1x87 P403n1x87 Awaiting requested review from P403n1x87 P403n1x87 is a code owner automatically assigned from DataDog/python-guild

@quinna-h quinna-h Awaiting requested review from quinna-h quinna-h is a code owner automatically assigned from DataDog/apm-idm-python

Assignees
No one assigned
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gnufede @juanjux @brettlangdon @Kyle-Verhoog @KowalskiThomas @christophe-papazian @vitor-de-araujo